dgram: clean up private APIs #21923
Merged
dgram: clean up private APIs #21923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
the
semver-major
apapirovski
approved these changes
Jul 22, 2018
lib/dgram.js
Outdated
| this._receiving = false; | ||
| this._bindState = BIND_STATE_UNBOUND; | ||
| this[async_id_symbol] = this._handle.getAsyncId(); | ||
| state.handle = handle; |
There was a problem hiding this comment.
It feels a bit cleaner if these were all declared directly on the state object. Meaning:
const state = {
handle,
receiving: false,
...etc,
};
jasnell
reviewed
Jul 23, 2018
lib/dgram.js
Outdated
| // Deprecated private APIs. | ||
| Object.defineProperty(Socket.prototype, '_handle', { | ||
| get: util.deprecate(function() { | ||
| console.log(this); |
There was a problem hiding this comment.
why is the console.log(this) added?
There was a problem hiding this comment.
Because I forgot to remove it facepalm
geek
approved these changes
Jul 23, 2018
4 tasks
mcollina
approved these changes
Jul 27, 2018
cjihrig
force-pushed
the
dgram
branch
3 times, most recently
from
c189e0a
to
ec00636
Compare
cjihrig
removed
the
semver-major
|
Addressed nits. Backed out the deprecations, and instead added getters/setters so that the PR is no longer semver-major. I'm going to open a follow up semver-major PR that reimplements the deprecations only. For now, this shouldn't cause problems for other PRs. CI: https://ci.nodejs.org/job/node-test-pull-request/16043/ EDIT: CI was green |
These methods are private APIs of dgram sockets, but do not need to be exposed via the Socket prototype. PR-URL: nodejs#21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
dgram sockets have a fair number of exposed private properties. This commit hides them all behind a single symbol property. PR-URL: nodejs#21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
_createSocketHandle() is used internally by the cluster module. This commit makes it internal only API. PR-URL: nodejs#21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit makes all previously private APIs available via getters, setters, and wrapper functions. PR-URL: nodejs#21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
These methods are private APIs of dgram sockets, but do not need to be exposed via the Socket prototype. PR-URL: #21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
dgram sockets have a fair number of exposed private properties. This commit hides them all behind a single symbol property. PR-URL: #21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
_createSocketHandle() is used internally by the cluster module. This commit makes it internal only API. PR-URL: #21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
This commit makes all previously private APIs available via getters, setters, and wrapper functions. PR-URL: #21923 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This was referenced Aug 1, 2018
This was referenced Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes