test: check arg type for dnsPromises.resolve to increase coverage. #22000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jul 27, 2018
cjihrig
approved these changes
Jul 27, 2018
jasnell
approved these changes
Jul 27, 2018
lpinca
approved these changes
Jul 27, 2018
trivikr
approved these changes
Aug 1, 2018
trivikr
added
the
author ready
|
Hopefully one last resume CI to fix Windows: https://ci.nodejs.org/job/node-test-pull-request/16162/ |
shisama
force-pushed
the
test-dns-resolve-type-check
branch
from
b5ed53e
to
cbec284
Compare
|
@trivikr @maclover7 Thank you to run CI again. But CI failed. I'm not sure that rebasing this will resolve the problems but I tried to rebase. If you don't mind, could you please run CI again? |
trivikr
approved these changes
Aug 7, 2018
|
Landed in 0b85435 |
trivikr
pushed a commit
that referenced
this pull request
Aug 7, 2018
PR-URL: #22000 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
PR-URL: #22000 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes