Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick dbfcc48 from upstream V8 #22251

Closed
wants to merge 3 commits into from
Closed

deps: cherry-pick dbfcc48 from upstream V8 #22251

wants to merge 3 commits into from

Commits on Sep 14, 2018

  1. deps: cherry-pick dbfcc48 from upstream V8 

    Original commit message:
```
[inspector] added V8InspectorClient::resourceNameToUrl

Some clients (see Node.js) use platform path as ScriptOrigin.
Reporting platform path in protocol makes using protocol much harder.
This CL introduced V8InspectorClient::resourceNameToUrl method that
is called for any reported using protocol url.
V8Inspector uses url internally as well so protocol client may generate
pattern for blackboxing with file urls only and does not need to build
complicated regexp that covers files urls and platform paths on
different platforms.

R=lushnikov@chromium.org
TBR=yangguo@chromium.org

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iff302e7441df922fa5d689fe510f5a9bfd470b9b
Reviewed-on: https://chromium-review.googlesource.com/1164624
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55029}
```
Refs: v8/v8@dbfcc48
Needed for #22223
    @alexkozy
    alexkozy committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    0218017 View commit details
    Browse the repository at this point in the history

  2. src: added URL::FromFilePath method 

    Method returns file URL from native file path.
    @alexkozy
    alexkozy committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    251677f View commit details
    Browse the repository at this point in the history

  3. inspector: implemented V8InspectorClient::resourceNameToUrl 

    This method is required by inspector to report normalized urls over
the protocol.

Fixes #22223
    @alexkozy
    alexkozy committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    a8a63c2 View commit details
    Browse the repository at this point in the history