Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update wrapping-related documentation #22363

Closed
wants to merge 1 commit into from
Closed

doc: update wrapping-related documentation #22363

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/573/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Aug 16, 2018
@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 17, 2018
@BridgeAR
Copy link
Member

Collaborators, please +1 if you are fine to fast track this.

@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16595/

@gabrielschulhof
Copy link
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/16597/

@gabrielschulhof
Copy link
Contributor Author

Resumed again as: https://ci.nodejs.org/job/node-test-pull-request/16602/

@gabrielschulhof
Copy link
Contributor Author

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/16603/

doc: update wrapping-related documentation
f6ba436 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.
@gabrielschulhof
Copy link
Contributor Author

Rebased to hopefully fix CI.

New CI: https://ci.nodejs.org/job/node-test-pull-request/16607/

Re: nodejs/build#1467 (comment)

@gabrielschulhof
Copy link
Contributor Author

CI Resumed as https://ci.nodejs.org/job/node-test-pull-request/16613/

@gabrielschulhof
Copy link
Contributor Author

And another CI from the top: https://ci.nodejs.org/job/node-test-pull-request/16614/

@gabrielschulhof
Copy link
Contributor Author

Landed in e19aa2663149fa2770d2cdfcca3ee54447fec2b7.

@gabrielschulhof gabrielschulhof deleted the n-api-fix-wrap-doc branch August 20, 2018 18:42
@gabrielschulhof
Copy link
Contributor Author

sigh

Forgot to git push origin master. The new commitid is 9dae0ae.

gabrielschulhof pushed a commit that referenced this pull request Aug 21, 2018
doc: update wrapping-related documentation
9dae0ae 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Aug 24, 2018
@targos
doc: update wrapping-related documentation
83f6582 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@targos
doc: update wrapping-related documentation
282a45d 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gabrielschulhof @nodejs-github-bot @BridgeAR @jasnell @lpinca @cjihrig @JungMinu @trivikr