crypto: move process.binding('tls_wrap') internal #22429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
33 tasks
danbev
added
the
semver-major
addaleax
approved these changes
Aug 21, 2018
jasnell
approved these changes
Aug 21, 2018
BridgeAR
approved these changes
Aug 21, 2018
trivikr
approved these changes
Aug 22, 2018
danbev
force-pushed
the
tls_wrap_move_to_internalBinding
branch
from
95b309f
to
b2f82d2
Compare
This commit makes the tls_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tls_wrap')
to use internalBinding instead.
Refs: nodejs#22160
danbev
force-pushed
the
tls_wrap_move_to_internalBinding
branch
from
b2f82d2
to
e0c6943
Compare
|
Rebased (resolved conflicts) CI: https://ci.nodejs.org/job/node-test-pull-request/16718/ |
|
Re-run of failing node-test-commit-freebsd was successful. |
|
Landed in eab916c. |
danbev
added a commit
that referenced
this pull request
Aug 24, 2018
This commit makes the tls_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tls_wrap')
to use internalBinding instead.
Refs: #22160
PR-URL: #22429
Refs: #22160
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the tls_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tls_wrap')
to use internalBinding instead.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes