Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: merge onread handlers for http2 streams & net.Socket #22449

Closed
wants to merge 2 commits into from
Closed

lib: merge onread handlers for http2 streams & net.Socket #22449

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This is a rebased & modified version of @aks-’s #20993, with tests passing locally

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/621/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem. labels Aug 21, 2018
@addaleax addaleax added this to To do in StreamBase refactor via automation Aug 21, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16652/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1518/
HTTP/2 Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/226/
Net Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/227/

@addaleax addaleax mentioned this pull request Aug 21, 2018
Closed
4 tasks
cjihrig
cjihrig approved these changes Aug 22, 2018
View reviewed changes
lib/internal/stream_base_commons.js Outdated
const { internalBinding } = require('internal/bootstrap/loaders');
const { WriteWrap } = internalBinding('stream_wrap');
const { UV_EOF } = process.binding('uv');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be internalBinding() now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@addaleax
Copy link
Member Author

Addressed the review comment

CI: https://ci.nodejs.org/job/node-test-pull-request/16803/
HTTP/2 benchmark CI with more iterations: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/230/ (scheduled)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@addaleax
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16896/

@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

Landed in 1126dfe

@addaleax addaleax closed this Sep 2, 2018
StreamBase refactor automation moved this from To do to Done Sep 2, 2018
@addaleax addaleax deleted the merge-net-socket-onread branch September 2, 2018 11:45
addaleax pushed a commit that referenced this pull request Sep 2, 2018
@aks- @addaleax
lib: merge onread handlers for http2 streams & net.Socket
1126dfe 
Refs: #20993
Co-authored-by: Anna Henningsen <anna@addaleax.net>

PR-URL: #22449
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
@aks- @targos
lib: merge onread handlers for http2 streams & net.Socket
45a6108 
Refs: #20993
Co-authored-by: Anna Henningsen <anna@addaleax.net>

PR-URL: #22449
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@aks- @targos
lib: merge onread handlers for http2 streams & net.Socket
f0be053 
Refs: #20993
Co-authored-by: Anna Henningsen <anna@addaleax.net>

PR-URL: #22449
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@aks- @targos
lib: merge onread handlers for http2 streams & net.Socket
2a88731 
Refs: #20993
Co-authored-by: Anna Henningsen <anna@addaleax.net>

PR-URL: #22449
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
@kjin kjin mentioned this pull request Oct 3, 2018
Closed
4 tasks
@addaleax addaleax mentioned this pull request Oct 20, 2018
Closed
2 tasks
@imcotton imcotton mentioned this pull request May 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem.
Projects
No open projects
StreamBase refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @aks-