Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: import acorn@5.7.2 #22488

Closed
wants to merge 3 commits into from
Closed

deps: import acorn@5.7.2 #22488

wants to merge 3 commits into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Aug 23, 2018

Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@rubys
deps: import acorn@5.7.1
c67b9e2 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in nodejs#22405.
@nodejs-github-bot
Copy link
Collaborator

@rubys build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/652/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 23, 2018
refack
refack approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@refack
Copy link
Contributor

refack commented Aug 23, 2018

/CC @TimothyGu

BridgeAR
BridgeAR approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

TimothyGu
TimothyGu reviewed Aug 23, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I admittedly haven't been too diligent on upgrading Acorn… Would you mind regenerating the LICENSE.md file by running tools/license-builder.sh?

@rubys
[squashme] update license
4ab713e 
update produced by tools/license-builder.sh
jdalton
jdalton suggested changes Aug 23, 2018
View reviewed changes
Copy link
Member

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding to see if acorn can bump changes in their master so that we can upgrade to the more recent latest and greatest. (if not possible in a few days I'll release the hold)

@rubys
Copy link
Member Author

rubys commented Aug 24, 2018

@jdalton "Latest commit bba80ab 17 days ago". Are you pursuing a release or there something I should be doing to make this happen?

@jdalton
Copy link
Member

jdalton commented Aug 24, 2018 •
edited

@rubys Just a release. Nothing you need to do (beside bump the acorn dep in the PR when appropriate). Their last release was mid June so if they are able to bump then we'll get more fresh bits is all.

@rubys
Copy link
Member Author

rubys commented Aug 24, 2018

@jdaldon, let me rephrase the question. Are you aware of the acorn team actively preparing a release, or has somebody asked them to produce a release, or are we merely delaying on the off chance that a release coincidentally happens in the next few days?

@jdalton
Copy link
Member

jdalton commented Aug 24, 2018 •
edited

@rubys

Are you aware of the acorn team actively preparing a release, or has somebody asked them to produce a release

Yes, I've inquired about a release.

@rubys
Copy link
Member Author

rubys commented Aug 24, 2018

@jdalton done. Thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/16719/

@rubys rubys changed the title deps: import acorn@5.7.1 deps: import acorn@5.7.2 Aug 24, 2018
refack
refack approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still RSLGTM

@refack
Copy link
Contributor

refack commented Aug 25, 2018

Resume CI: https://ci.nodejs.org/job/node-test-commit/20908/

@rubys
Copy link
Member Author

rubys commented Aug 26, 2018

Failures: https://ci.nodejs.org/job/node-test-binary-windows/19527/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

17:23:33 ERROR: Error fetching remote repo 'jenkins_tmp'
17:23:33 hudson.plugins.git.GitException: Failed to fetch from binary_tmp@147.75.70.237:binary_tmp.git
17:23:33 stderr: fatal: Unable to create 'c:/workspace/node-test-binary-windows/.git/index.lock': File exists.
17:23:33 
17:23:33 Another git process seems to be running in this repository, e.g.
17:23:33 an editor opened by 'git commit'.

trivikr
trivikr approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

rubys added a commit to rubys/node that referenced this pull request Aug 26, 2018
@rubys
deps: import acorn@5.7.2
49bfc37 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in nodejs#22405.

PR-URL: nodejs#22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@rubys
Copy link
Member Author

rubys commented Aug 26, 2018

landed: 49bfc37

@rubys rubys closed this Aug 26, 2018
addaleax pushed a commit that referenced this pull request Aug 27, 2018
@rubys @addaleax
deps: import acorn@5.7.2
d47e342 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@rubys @targos
deps: import acorn@5.7.2
aa22dc8 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@rubys @targos
deps: import acorn@5.7.2
6405ad9 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton approved these changes

@refack refack refack approved these changes

@bengl bengl bengl approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rubys @nodejs-github-bot @refack @jdalton @bengl @TimothyGu @BridgeAR @trivikr