Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify fallback behavior of module require #22494

Closed
wants to merge 1 commit into from
Closed

doc: clarify fallback behavior of module require #22494

wants to merge 1 commit into from

Conversation

TomCoded
Copy link
Contributor

fixes: #22464

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Aug 24, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/657/

@vsemozhetbyt
Copy link
Contributor

I am not sure if this is an appropriate team, correct me if I am wrong: cc @nodejs/modules

@TomCoded
Copy link
Contributor Author

See new discussion at #22464 re: whether the documented behavior is a bug.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@addaleax
Copy link
Member

I think this is ready apart from the fact that it’s not 100 % clear to me that it fully resolves #22464. But if there are no objections in the near future, I’ll go ahead and merge this as-is (i.e. with the Fixes: tag).

@addaleax
Copy link
Member

addaleax commented Sep 2, 2018

Landed in 594dd42, thanks for the PR!

@addaleax addaleax closed this Sep 2, 2018
addaleax pushed a commit that referenced this pull request Sep 2, 2018
@TomCoded @addaleax
doc: clarify fallback behavior of module require
594dd42 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
@TomCoded @targos
doc: clarify fallback behavior of module require
17bc49e 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@TomCoded @targos
doc: clarify fallback behavior of module require
7d8ef42 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@TomCoded @targos
doc: clarify fallback behavior of module require
f0208b3 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folders as Modules docs: Inaccuracy regarding missing main file?
5 participants
@TomCoded @vsemozhetbyt @addaleax @gdams @nodejs-github-bot