tools: add missing package-lock to clang-format #22500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore.
targos
added
tools
nodejs-github-bot
added
meta
|
Please 👍 this comment to fast-track. |
|
The lite pipeline CI should be enough for this change. |
danbev
approved these changes
Aug 24, 2018
lpinca
approved these changes
Aug 24, 2018
trivikr
approved these changes
Aug 24, 2018
cjihrig
approved these changes
Aug 24, 2018
2 tasks
refack
approved these changes
Aug 24, 2018
|
Dup of #22481 😄 |
|
@refack oops sorry! I only searched for "clang-format" |
Well I missed the |
addaleax
added
the
author ready
jasnell
approved these changes
Aug 25, 2018
targos
added a commit
to targos/node
that referenced
this pull request
Aug 25, 2018
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: nodejs#22500 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in e10290c |
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: #22500 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 3, 2018
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: #22500 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
`npm ci` fails where there is no package-lock.json. Also add the `node_modules` directory to .gitignore. PR-URL: #22500 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm cifails where there is no package-lock.json.Also add the
node_modulesdirectory to .gitignore.