Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add GitHub email set up link to COLLABORATOR_GUIDE #22525

Closed
wants to merge 2 commits into from
Closed

doc: add GitHub email set up link to COLLABORATOR_GUIDE #22525

wants to merge 2 commits into from

Conversation

lundibundi
Copy link
Member

Checklist
  • make -j4 test (UNIX) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/672/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 25, 2018
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018
cjihrig
cjihrig reviewed Aug 25, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of saying "this and this guides" how about linking from the words "username" and "email" and dropping the part about guides.

@lundibundi
Copy link
Member Author

@cjihrig seems good to me.

@lundibundi lundibundi removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018
@lundibundi
Copy link
Member Author

New CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/673/pipeline/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018
@gdams
Copy link
Member

gdams commented Aug 26, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@gdams gdams added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 26, 2018
@gdams
Copy link
Member

gdams commented Aug 26, 2018

landed as fast-track in: 317b894

@gdams gdams closed this Aug 26, 2018
gdams pushed a commit that referenced this pull request Aug 26, 2018
@lundibundi
doc: add GitHub email set up link to COLLABORATOR_GUIDE
317b894 
PR-URL: #22525
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 27, 2018
@lundibundi @addaleax
doc: add GitHub email set up link to COLLABORATOR_GUIDE
349bfdc 
PR-URL: #22525
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@lundibundi @targos
doc: add GitHub email set up link to COLLABORATOR_GUIDE
46063b8 
PR-URL: #22525
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@lundibundi @targos
doc: add GitHub email set up link to COLLABORATOR_GUIDE
2ee0ef1 
PR-URL: #22525
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lundibundi @nodejs-github-bot @gdams @refack @cjihrig @vsemozhetbyt @trivikr