Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in test name #22605

Closed
wants to merge 1 commit into from
Closed

test: fix typo in test name #22605

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 30, 2018

Correct test name to reflect the module it tests (trace_events).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: fix typo in test name
3a05926 
Correct test name to reflect the module it tests (`trace_events`).
@Trott Trott added the test Issues and PRs related to the tests. label Aug 30, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/734/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 30, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 30, 2018
@Trott
Copy link
Member Author

Trott commented Aug 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16876/

@Trott
Copy link
Member Author

Trott commented Aug 30, 2018

👍 this comment to approve fast-tracking.

@Trott
Copy link
Member Author

Trott commented Aug 30, 2018

Landed in 366ffdc

@Trott Trott closed this Aug 30, 2018
Trott added a commit to Trott/io.js that referenced this pull request Aug 30, 2018
@Trott
test: fix typo in test name
366ffdc 
Correct test name to reflect the module it tests (`trace_events`).

PR-URL: nodejs#22605
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@Trott @addaleax
test: fix typo in test name
48af430 
Correct test name to reflect the module it tests (`trace_events`).

PR-URL: #22605
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@Trott @targos
test: fix typo in test name
82732ef 
Correct test name to reflect the module it tests (`trace_events`).

PR-URL: #22605
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott @targos
test: fix typo in test name
acaa918 
Correct test name to reflect the module it tests (`trace_events`).

PR-URL: #22605
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
@Trott Trott deleted the fix-typo-in-test-name branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trott @nodejs-github-bot @lpinca @cjihrig @richardlau