Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: allow UTF-16 in generic StringBytes decode call #22622

Closed
wants to merge 2 commits into from
Closed

src: allow UTF-16 in generic StringBytes decode call #22622

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: #22358

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
src: allow UTF-16 in generic StringBytes decode call
829e99b 
This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: nodejs#22358
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/744/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 31, 2018
@addaleax addaleax added buffer Issues and PRs related to the buffer subsystem. string_decoder Issues and PRs related to the string_decoder subsystem. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Aug 31, 2018
@addaleax
Copy link
Member Author

addaleax commented Aug 31, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/16904/
CI: https://ci.nodejs.org/job/node-test-pull-request/16905/ (:heavy_check_mark:)

@addaleax addaleax mentioned this pull request Aug 31, 2018
Closed
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 3, 2018

Landed in 71f633a

@addaleax addaleax closed this Sep 3, 2018
@addaleax addaleax deleted the fix-utf16 branch September 3, 2018 20:36
addaleax added a commit that referenced this pull request Sep 3, 2018
@addaleax
src: allow UTF-16 in generic StringBytes decode call
71f633a 
This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: #22358

PR-URL: #22622
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Sep 3, 2018
@addaleax
src: allow UTF-16 in generic StringBytes decode call
1ce2ea3 
This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: #22358

PR-URL: #22622
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Sep 5, 2018
@addaleax @targos
src: allow UTF-16 in generic StringBytes decode call
4e65198 
This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: #22358

PR-URL: #22622
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@addaleax @targos
src: allow UTF-16 in generic StringBytes decode call
79556e5 
This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: #22358

PR-URL: #22622
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 6, 2018
Closed
Closed
addaleax added a commit to addaleax/node that referenced this pull request Oct 1, 2019
@addaleax
crypto: remove arbitrary UTF16 restriction
c702726 
Since 71f633a, this is no longer necessary.

Refs: nodejs#22622
Fixes: nodejs#29793
@addaleax addaleax mentioned this pull request Oct 1, 2019
Closed
4 tasks
Trott pushed a commit that referenced this pull request Oct 3, 2019
@addaleax @Trott
crypto: remove arbitrary UTF16 restriction
389969e 
Since 71f633a, this is no longer necessary.

Refs: #22622
Fixes: #29793

PR-URL: #29795
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@addaleax @BridgeAR
crypto: remove arbitrary UTF16 restriction
ab4c53e 
Since 71f633a, this is no longer necessary.

Refs: #22622
Fixes: #29793

PR-URL: #29795
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. lib / src Issues and PRs related to general changes in the lib or src directory. string_decoder Issues and PRs related to the string_decoder subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault on v10.7.0
3 participants
@addaleax @nodejs-github-bot @tniessen