Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-gc-tls-external-memory #22651

Closed
wants to merge 1 commit into from
Closed

test: refactor test-gc-tls-external-memory #22651

wants to merge 1 commit into from

Commits on Sep 2, 2018

  1. test: refactor test-gc-tls-external-memory 

    - Don’t use network connections, we don’t need them and
  they add more native objects into the mix when we care
  about other kinds of native objects.
- Run GC only once every 64 iterations – this cuts down
  running time from 4 s to 400 ms.
- Use `common.mustCall()` for the `connect()` handler.
- Make sure that the TLS sockets do get garbage collected,
  since the test would otherwise also pass if they remain
  alive indefinitely.
    @addaleax
    addaleax committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    ddb45bd View commit details
    Browse the repository at this point in the history