src: remove calls to deprecated V8 functions (Int32Value) #22662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all calls to deprecated V8 functions (here: Value::Int32Value) inside the code.
nodejs-github-bot
added
c++
addaleax
approved these changes
Sep 2, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16962/ (:heavy_check_mark:) |
JungMinu
approved these changes
Sep 3, 2018
jasnell
approved these changes
Sep 4, 2018
ryzokuken
approved these changes
Sep 4, 2018
BridgeAR
added
the
author ready
|
Landed in 594a84d. |
danbev
pushed a commit
that referenced
this pull request
Sep 5, 2018
Remove all calls to deprecated V8 functions (here: Value::Int32Value) inside the code. PR-URL: #22662 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 5, 2018
Remove all calls to deprecated V8 functions (here: Value::Int32Value) inside the code. PR-URL: #22662 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
Remove all calls to deprecated V8 functions (here: Value::Int32Value) inside the code. PR-URL: #22662 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all calls to deprecated V8 functions (here: Value::Int32Value)
inside the code.
/cc @ryzokuken @addaleax @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes