deps: fix V8 test regression #22677
Closed
deps: fix V8 test regression #22677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea
targos
added
v8 engine
nodejs-github-bot
added
the
v8 engine
|
Please 👍 this comment to fast-track. V8 CI is broken without this change. |
2 tasks
addaleax
approved these changes
Sep 3, 2018
cjihrig
approved these changes
Sep 3, 2018
mihalskiy
approved these changes
Sep 3, 2018
apapirovski
approved these changes
Sep 4, 2018
|
Landed in ebc965f |
targos
added a commit
to targos/node
that referenced
this pull request
Sep 4, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea PR-URL: nodejs#22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos
added a commit
that referenced
this pull request
Sep 5, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in a V8 backport PR.
A small change in cctest/test-log.cc was forgotten.
Refs: #22028
Refs: v8/v8@ba752ea