Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove usage of deprecated V8 APIs in addons #22704

Closed
wants to merge 1 commit into from
Closed

test: remove usage of deprecated V8 APIs in addons #22704

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 5, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/798/pipeline

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Sep 5, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Sep 5, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/17029/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
@targos
Copy link
Member Author

targos commented Sep 7, 2018

Landed in 8518548

@targos targos closed this Sep 7, 2018
@targos targos deleted the v8-dep-addon branch September 7, 2018 13:56
targos added a commit that referenced this pull request Sep 7, 2018
@targos
test: remove usage of deprecated V8 APIs in addons
8518548 
PR-URL: #22704
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Sep 7, 2018
@targos
test: remove usage of deprecated V8 APIs in addons
13b8011 
PR-URL: #22704
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@targos @nodejs-github-bot @BridgeAR @jasnell @trivikr @MylesBorins