Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update mmarchini's e-mail #22776

Closed
wants to merge 2 commits into from
Closed

doc: update mmarchini's e-mail #22776

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 9, 2018
@nodejs-github-bot
Copy link
Collaborator

@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/843/pipeline

addaleax
addaleax approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like, you can also add the new email as the first on in .mailmap, similar to what happens in #22771

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 9, 2018
@mmarchini
Copy link
Contributor Author

Done, thanks for the tip!

@Trott
Copy link
Member

Trott commented Sep 9, 2018

+1 to fast-tracking

Trott pushed a commit to Trott/io.js that referenced this pull request Sep 9, 2018
@mmarchini @Trott
doc: update mmarchini's e-mail
66f563d 
PR-URL: nodejs#22776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Sep 9, 2018

Landed in 66f563d

@Trott Trott closed this Sep 9, 2018
@Trott
Copy link
Member

Trott commented Sep 9, 2018 •
edited
Loading

(CI re-run with fixup commit: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/846/pipeline) ✔️

targos pushed a commit that referenced this pull request Sep 10, 2018
@mmarchini @targos
doc: update mmarchini's e-mail
9942117 
PR-URL: #22776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmarchini @nodejs-github-bot @Trott @addaleax @richardlau @BridgeAR