test: changing the hostname to an invalid name #2287
Conversation
|
Can you s/changing/change/ in the commit log? I have to admit I'm not super fond of the unrelated style changes. I'm not sure if this change will work on all platforms. Unfortunately, I can't start a test run because the CI is acting up. |
In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name 'blah.blah' and it fails with ETIMEOUT instead of ENOTFOUND. This patch changes the hostname to "...", an invalid name, so that it will fail immediately.
thefourtheye
force-pushed
the
fix-net-better-error-messages
branch
from
a00e56f
to
f1e6b18
Compare
|
@bnoordhuis Oh yeah, I updated the commit message. And regarding the CI, it will be fixed by Monday, I guess. |
|
I tried a CI run earlier today and it was successful on all the other boxes, except Fedora 22 and Ubuntu 15.04_64. https://jenkins-iojs.nodesource.com/job/node-test-pull-request/28/ |
|
Possibly related: nodejs/node-v0.x-archive#5545 |
|
LGTM if CI is happy |
|
Related: #2005 |
|
@evanlucas Yes, I feel that it is related. The name |
|
CI Run: node-test-commit/81 |
|
The test passes in all the machines. @bnoordhuis LGTY? |
|
LGTM |
In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name 'blah.blah' and it fails with ETIMEOUT instead of ENOTFOUND. This patch changes the hostname to "...", an invalid name, so that it will fail immediately. PR-URL: #2287 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Thanks, landed at 64cf711. |
In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name
'blah.blah' and it fails with
ETIMEOUTinstead ofENOTFOUND. This patchchanges the hostname to
..., an invalid name, so that it will failimmediately.
cc @evanlucas