Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add boneskull as collaborator #22917

Closed
wants to merge 1 commit into from
Closed

doc: add boneskull as collaborator #22917

wants to merge 1 commit into from

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Sep 17, 2018 •
edited by tniessen
Loading

woo!

Checklist

@boneskull boneskull added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 17, 2018
@nodejs-github-bot
Copy link
Collaborator

@boneskull build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/916/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 17, 2018
Trott
Trott approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to fast-tracking.

@boneskull
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17264/

@tniessen
Copy link
Member

I approve fast-tracking.

devsnek
devsnek approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome aboard! :shipit:

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 17, 2018
@boneskull
Copy link
Contributor Author

Landed in 8df13ec

@boneskull boneskull closed this Sep 17, 2018
@boneskull boneskull deleted the onboarding branch September 17, 2018 21:46
boneskull added a commit that referenced this pull request Sep 17, 2018
@boneskull
doc: add boneskull as collaborator
8df13ec 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 18, 2018
@boneskull @targos
doc: add boneskull as collaborator
da2c303 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@boneskull @targos
doc: add boneskull as collaborator
97f6ff3 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 20, 2018
@boneskull @targos
doc: add boneskull as collaborator
6e9f1d6 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

@devsnek devsnek devsnek approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@boneskull @nodejs-github-bot @tniessen @Trott @devsnek @vsemozhetbyt