Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: only stop inspector if started #22927

Closed
wants to merge 1 commit into from

Commits on Sep 18, 2018

  1. worker: only stop inspector if started

    This may fix some flakiness with tests that use `worker.terminate()`.
    In particular, the following failure seems like it could be related
    (no consistent reproduction available, though):
    
    ```
    15:30:14 not ok 187 parallel/test-heapdump-worker
    15:30:14   ---
    15:30:14   duration_ms: 2.499
    15:30:14   severity: fail
    15:30:14   exitcode: 134
    15:30:14   stack: |-
    15:30:14     npm[6904]: src\inspector_agent.cc:729: Assertion `(client_) != nullptr' failed.
    ```
    
    From https://ci.nodejs.org/job/node-test-binary-windows/20041/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console
    
    Refs: nodejs#22769
    addaleax committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    44f0aba View commit details
    Browse the repository at this point in the history