test: remove common.hasSmallICU #22937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith.
richardlau
approved these changes
Sep 18, 2018
Trott
added
the
author ready
targos
approved these changes
Sep 18, 2018
cjihrig
approved these changes
Sep 18, 2018
tniessen
approved these changes
Sep 18, 2018
BridgeAR
approved these changes
Sep 18, 2018
refack
reviewed
Sep 18, 2018
| @@ -1,7 +1,9 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| const os = require('os'); | |||
| if (!(common.hasIntl && common.hasSmallICU)) | |||
|
|
|||
| const { hasSmallICU } = process.binding('config'); | |||
There was a problem hiding this comment.
Bonus points: process.config.variables.icu_small
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17306/ |
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20841/ |
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20843/ ✔️ |
thefourtheye
approved these changes
Sep 19, 2018
lpinca
approved these changes
Sep 20, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 20, 2018
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: nodejs#22937 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 3cb663a |
targos
pushed a commit
that referenced
this pull request
Sep 21, 2018
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: #22937 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the
commonmonolith.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes