win,msi: highlight installation of 3rd-party tools #23003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script. Refs: nodejs#22645 Refs: nodejs#22988
nodejs-github-bot
added
install
2 tasks
|
cc @nodejs/platform-windows |
refack
approved these changes
Sep 23, 2018
|
@joaocgreis are you sure we don't need to show some license or EULA? |
joaocgreis
reviewed
Sep 23, 2018
tools/msvs/msi/i18n/en-us.wxl
Outdated
| @@ -14,7 +14,7 @@ | |||
| <String Id="NativeToolsDlgBannerBitmap">WixUI_Bmp_Banner</String> | |||
| <String Id="NativeToolsDlgIntro">Some npm modules need to be compiled from C/C++ when installing. If you want to be able to install such modules, some tools (Python 2 and Visual Studio Build Tools) need to be installed.</String> | |||
| <String Id="NativeToolsDlgInstallCheckbox">Automatically install the necessary tools. The script will pop-up in a new window after the installation completes.</String> | |||
| <String Id="NativeToolsDlgManualDetails">Alternatively, follow the instructions at <![CDATA[<a href="https://github.com/nodejs/node-gyp#on-windows">https://github.com/nodejs/node-gyp#on-windows</a>]]> to install the dependencies yourself.</String> | |||
| <String Id="NativeToolsDlgManualDetails">Note that this will also install Boxstarter and Chocolatey. Alternatively, follow the instructions at <![CDATA[<a href="https://github.com/nodejs/node-gyp#on-windows">https://github.com/nodejs/node-gyp#on-windows</a>]]> to install the dependencies yourself.</String> | |||
There was a problem hiding this comment.
This should go at the end of the line above, and actually fits there nicely. It makes sense to me to keep the line above (that goes next to the checkbox) about automatic installation and this one about pointing users to instructions to install manually.
joaocgreis
approved these changes
Sep 24, 2018
|
@refack I'm never too sure about licenses. But we can add a note, I'll look into that. |
2 tasks
|
Landed in b78ba93. |
tniessen
added a commit
that referenced
this pull request
Sep 24, 2018
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script. PR-URL: #23003 Refs: #22645 Refs: #22988 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
2 tasks
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script. PR-URL: #23003 Refs: #22645 Refs: #22988 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script.
Refs: #22645
Refs: #22988
Checklist