test: modernize JS in some test-fs-*.js

test/parallel/test-fs-access.js

@@ -59,10 +59,9 @@ if (!common.isWindows && process.getuid() === 0) {
   }
 }
 
-assert.strictEqual(typeof fs.F_OK, 'number');
-assert.strictEqual(typeof fs.R_OK, 'number');
-assert.strictEqual(typeof fs.W_OK, 'number');
-assert.strictEqual(typeof fs.X_OK, 'number');
+[fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK].forEach(
+  (cons) => assert.strictEqual(typeof cons, 'number')
+);
 
 const throwNextTick = (e) => { process.nextTick(() => { throw e; }); };
 

test/parallel/test-fs-append-file-sync.js

@@ -39,17 +39,21 @@ const data = '南越国是前203年至前111年存在于岭南地区的一个国
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-// test that empty file will be created and have content added
+// the used files
 const filename = join(tmpdir.path, 'append-sync.txt');
+const filename2 = join(tmpdir.path, 'append-sync2.txt');
+const filename3 = join(tmpdir.path, 'append-sync3.txt');
+const filename4 = join(tmpdir.path, 'append-sync4.txt');
+const filename5 = join(tmpdir.path, 'append-sync5.txt');
 
+// test that empty file will be created and have content added
 fs.appendFileSync(filename, data);
 
 const fileData = fs.readFileSync(filename);
 
 assert.strictEqual(Buffer.byteLength(data), fileData.length);
 
 // test that appends data to a non empty file
-const filename2 = join(tmpdir.path, 'append-sync2.txt');
 fs.writeFileSync(filename2, currentFileData);
 
 fs.appendFileSync(filename2, data);
@@ -60,7 +64,6 @@ assert.strictEqual(Buffer.byteLength(data) + currentFileData.length,
                    fileData2.length);
 
 // test that appendFileSync accepts buffers
-const filename3 = join(tmpdir.path, 'append-sync3.txt');
 fs.writeFileSync(filename3, currentFileData);
 
 const buf = Buffer.from(data, 'utf8');
@@ -71,7 +74,6 @@ const fileData3 = fs.readFileSync(filename3);
 assert.strictEqual(buf.length + currentFileData.length, fileData3.length);
 
 // test that appendFile accepts numbers.
-const filename4 = join(tmpdir.path, 'append-sync4.txt');
 fs.writeFileSync(filename4, currentFileData, { mode: m });
 
 fs.appendFileSync(filename4, num, { mode: m });
@@ -88,7 +90,6 @@ assert.strictEqual(Buffer.byteLength(String(num)) + currentFileData.length,
                    fileData4.length);
 
 // test that appendFile accepts file descriptors
-const filename5 = join(tmpdir.path, 'append-sync5.txt');
 fs.writeFileSync(filename5, currentFileData);
 
 const filename5fd = fs.openSync(filename5, 'a+', 0o600);

test/parallel/test-fs-copyfile.js

@@ -36,12 +36,9 @@ function verify(src, dest) {
 tmpdir.refresh();
 
 // Verify that flags are defined.
-assert.strictEqual(typeof COPYFILE_EXCL, 'number');
-assert.strictEqual(typeof COPYFILE_FICLONE, 'number');
-assert.strictEqual(typeof COPYFILE_FICLONE_FORCE, 'number');
-assert.strictEqual(typeof UV_FS_COPYFILE_EXCL, 'number');
-assert.strictEqual(typeof UV_FS_COPYFILE_FICLONE, 'number');
-assert.strictEqual(typeof UV_FS_COPYFILE_FICLONE_FORCE, 'number');
+[COPYFILE_EXCL, COPYFILE_FICLONE, COPYFILE_FICLONE_FORCE, UV_FS_COPYFILE_EXCL,
+ UV_FS_COPYFILE_FICLONE, UV_FS_COPYFILE_FICLONE_FORCE]
+  .forEach((cons) => assert.strictEqual(typeof cons, 'number'));
 assert.strictEqual(COPYFILE_EXCL, UV_FS_COPYFILE_EXCL);
 assert.strictEqual(COPYFILE_FICLONE, UV_FS_COPYFILE_FICLONE);
 assert.strictEqual(COPYFILE_FICLONE_FORCE, UV_FS_COPYFILE_FICLONE_FORCE);

test/parallel/test-fs-open-flags.js

@@ -29,15 +29,9 @@ const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
 
-const O_APPEND = fs.constants.O_APPEND || 0;
-const O_CREAT = fs.constants.O_CREAT || 0;
-const O_EXCL = fs.constants.O_EXCL || 0;
-const O_RDONLY = fs.constants.O_RDONLY || 0;
-const O_RDWR = fs.constants.O_RDWR || 0;
-const O_SYNC = fs.constants.O_SYNC || 0;
-const O_DSYNC = fs.constants.O_DSYNC || 0;
-const O_TRUNC = fs.constants.O_TRUNC || 0;
-const O_WRONLY = fs.constants.O_WRONLY || 0;
+// 0 if not found in fs.constants
+const { O_APPEND = 0, O_CREAT = 0, O_EXCL = 0, O_RDONLY = 0, O_RDWR = 0,
+        O_SYNC = 0, O_DSYNC = 0, O_TRUNC = 0, O_WRONLY = 0 } = fs.constants;
 
 const { stringToFlags } = require('internal/fs/utils');
 

test/parallel/test-fs-open-mode-mask.js

@@ -7,13 +7,8 @@ const assert = require('assert');
 const path = require('path');
 const fs = require('fs');
 
-let mode;
+const mode = common.isWindows ? 0o444 : 0o644;
 
-if (common.isWindows) {
-  mode = 0o444;
-} else {
-  mode = 0o644;
-}
 
 const maskToIgnore = 0o10000;
 

test/parallel/test-fs-stat-bigint.js

@@ -30,34 +30,10 @@ function verifyStats(bigintStats, numStats) {
         `Number version ${time}, BigInt version ${time2}n`);
     } else if (key === 'mode') {
       assert.strictEqual(bigintStats[key], BigInt(val));
-      assert.strictEqual(
-        bigintStats.isBlockDevice(),
-        numStats.isBlockDevice()
-      );
-      assert.strictEqual(
-        bigintStats.isCharacterDevice(),
-        numStats.isCharacterDevice()
-      );
-      assert.strictEqual(
-        bigintStats.isDirectory(),
-        numStats.isDirectory()
-      );
-      assert.strictEqual(
-        bigintStats.isFIFO(),
-        numStats.isFIFO()
-      );
-      assert.strictEqual(
-        bigintStats.isFile(),
-        numStats.isFile()
-      );
-      assert.strictEqual(
-        bigintStats.isSocket(),
-        numStats.isSocket()
-      );
-      assert.strictEqual(
-        bigintStats.isSymbolicLink(),
-        numStats.isSymbolicLink()
-      );
+      ['isBlockDevice', 'isCharacterDevice', 'isDirectory', 'isFIFO', 'isFile',
+       'isFile', 'isSocket', 'isSymbolicLink' ].forEach(
+        (fct) => assert.strictEqual(bigintStats[fct](), numStats[fct]()));
+
     } else if (common.isWindows && (key === 'blksize' || key === 'blocks')) {
       assert.strictEqual(bigintStats[key], undefined);
       assert.strictEqual(numStats[key], undefined);