Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: close fd in doSendFileFD() #23047

Merged
merged 1 commit into from
Sep 26, 2018
Merged

http2: close fd in doSendFileFD() #23047

merged 1 commit into from
Sep 26, 2018

Commits on Sep 26, 2018

  1. http2: close fd in doSendFileFD() 

    This commit closes the file descriptor in two code paths that
return from doSendFileFD().

PR-URL: nodejs#23047
Fixes: nodejs#23029
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @cjihrig
    cjihrig committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    af5d986 View commit details
    Browse the repository at this point in the history