doc: update guide for assert team #23085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Collaborator Guide to use the assert team for notifications on assert module issues and pull requests.
addaleax
approved these changes
Sep 25, 2018
cjihrig
approved these changes
Sep 25, 2018
vsemozhetbyt
approved these changes
Sep 25, 2018
vsemozhetbyt
added
the
author ready
lpinca
approved these changes
Sep 25, 2018
refack
approved these changes
Sep 25, 2018
trivikr
approved these changes
Sep 26, 2018
|
👍 this comment to fast-track. |
|
@Trott I thought the testing group was actually explicitly not comparable to |
BridgeAR
approved these changes
Sep 26, 2018
|
Landed in 884dbe9 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 27, 2018
Update the Collaborator Guide to use the assert team for notifications on assert module issues and pull requests. PR-URL: nodejs#23085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
Update the Collaborator Guide to use the assert team for notifications on assert module issues and pull requests. PR-URL: #23085 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Collaborator Guide to use the assert team for notifications
on assert module issues and pull requests.
/cc @BridgeAR
@nodejs/testing If anyone wants to be added to the team, let me know!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes