Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: don't send trailers on a closed connection #23146

Closed
wants to merge 1 commit into from
Closed

http2: don't send trailers on a closed connection #23146

wants to merge 1 commit into from

Commits on Sep 28, 2018

  1. http2: don't send trailers on a closed connection 

    There is a race condition between onStreamCloseResponse(), which
removes the wantTrailers listener, and Http2Stream.close(), which
will invalidate the connection. IE, sendTrailers can be called on
a closed connection which would crash with a:
Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed
    @edevil
    edevil committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    338cd60 View commit details
    Browse the repository at this point in the history