Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.6.1 #23149

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 5.6.1 #23149

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 28, 2018

Update ESLint to 5.6.1.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 5.6.1
e877ea2 
Update ESLint to 5.6.1.
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1052/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 28, 2018
Trott
Trott approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@Trott
Copy link
Member

Trott commented Sep 28, 2018

(Lite CI sufficient since that runs the linter.)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2018
jasnell
jasnell approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp lgtm

trivikr
trivikr approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

(Lite CI sufficient since that runs the linter.)

Sorry, I saw this after I started a full CI.

@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

Landed in bb00eda.

@danbev danbev closed this Oct 1, 2018
danbev pushed a commit that referenced this pull request Oct 1, 2018
@cjihrig @danbev
tools: update ESLint to 5.6.1
bb00eda 
Update ESLint to 5.6.1.

PR-URL: #23149
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@cjihrig cjihrig deleted the eslint branch October 1, 2018 12:53
targos pushed a commit that referenced this pull request Oct 1, 2018
@cjihrig @targos
tools: update ESLint to 5.6.1
11b6e7b 
Update ESLint to 5.6.1.

PR-URL: #23149
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
targos pushed a commit that referenced this pull request Oct 3, 2018
@cjihrig @targos
tools: update ESLint to 5.6.1
1cbc2ee 
Update ESLint to 5.6.1.

PR-URL: #23149
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cjihrig @nodejs-github-bot @Trott @danbev @silverwind @jasnell @trivikr