doc: improve instructions for verifying binaries #23248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify and clarify the text in README.md for verifying binaries.
addaleax
approved these changes
Oct 3, 2018
vsemozhetbyt
reviewed
Oct 3, 2018
| Current, LTS, and Nightly download directories all contain a SHASUMS256.txt | ||
| file that lists the SHA checksums for each file available for | ||
| download. | ||
| Download directories contain a SHASUMS256.txt file with SHA checksums for the |
There was a problem hiding this comment.
SHASUMS256.txt -> `SHASUMS256.txt` (with backticks)?
(Here and in all other mentions of SHASUMS256.txt and SHASUMS256.txt.sig if it is appropriate for this PR).
thefourtheye
approved these changes
Oct 4, 2018
Trott
added
the
author ready
BridgeAR
approved these changes
Oct 4, 2018
jasnell
approved these changes
Oct 5, 2018
|
Landed in 004f8b0 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 6, 2018
Simplify and clarify the text in README.md for verifying binaries. PR-URL: nodejs#23248 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 7, 2018
Simplify and clarify the text in README.md for verifying binaries. PR-URL: #23248 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 7, 2018
Simplify and clarify the text in README.md for verifying binaries. PR-URL: #23248 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Oct 12, 2018
Simplify and clarify the text in README.md for verifying binaries. PR-URL: nodejs#23248 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Simplify and clarify the text in README.md for verifying binaries. PR-URL: #23248 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and clarify the text in README.md for verifying binaries.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes