Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure error function call on inspector disabled #23586

Closed

Commits on Oct 12, 2018

  1. lib: migrate from process.binding to internalBinding

    We are migrating towards using internalBinding(\'options\').getOptions()
    instead of process.binding(\'config\') to access the value of the
    --experimental-vm-modules command line option.
    madeinjam committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    24f8b6d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2018

  1. test: ensure error function call on inspector disabled

    If the process.config.variables.v8_enable_inspector
    is undefined or set to 0 and the sendInspectorCommand
    function is called, it should call the error function
    and should NOT call the callback function.
    madeinjam committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    2431bca View commit details
    Browse the repository at this point in the history
  2. test: remove the process variable back up

    Since the process exists after the test, there is no need to backup and
    restore the process.config.variables.v8_enable_inspector variable.
    madeinjam committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    32a8115 View commit details
    Browse the repository at this point in the history