console: add trace-events for time and count #23703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
console
jasnell
added
trace_events
richardlau
reviewed
Oct 16, 2018
lpinca
approved these changes
Oct 17, 2018
richardlau
approved these changes
Oct 17, 2018
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log.
jasnell
force-pushed
the
trace-events-console
branch
from
9a432c0
to
cb9a2ce
Compare
|
New CI post rebase: https://ci.nodejs.org/job/node-test-pull-request/17976/ |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Oct 18, 2018
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: nodejs#23703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 9c82a1e |
|
Should this be backported to |
jasnell
added a commit
that referenced
this pull request
Oct 21, 2018
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: #23703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
3 tasks
andrewhughes101
pushed a commit
to andrewhughes101/node
that referenced
this pull request
Mar 4, 2020
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: nodejs#23703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 9, 2020
Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: #23703 Backport-PR-URL: #28840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
node.consoletrace event category to captureconsole.count(),console.countReset(),console.time(),console.timeLog(), andconsole.timeEnd()to the traceevent log.
Fairly simple utility here. Pairs nicely with trace events for the perf_hooks API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes