src: minor refactor to node_errors.h #23879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add overloads of the error generation/throwing methods that take an `Isolate*` argument, since the created objects don’t depend on the `Environment*` in question. Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way.
nodejs-github-bot
added
buffer
addaleax
added
errors
jasnell
approved these changes
Oct 25, 2018
eugeneo
approved these changes
Oct 25, 2018
cjihrig
approved these changes
Oct 25, 2018
src/node_buffer.cc
Outdated
| @@ -41,8 +41,7 @@ | |||
| #define THROW_AND_RETURN_IF_OOB(r) \ | |||
| do { \ | |||
| if (!(r)) \ | |||
| return node::THROW_ERR_OUT_OF_RANGE_WITH_TEXT(env, \ | |||
| "Index out of range"); \ | |||
| return node::THROW_ERR_OUT_OF_RANGE(env, "Index out of range"); \ | |||
There was a problem hiding this comment.
Extra space after the comma?
addaleax
added
the
author ready
mmarchini
approved these changes
Oct 26, 2018
|
Landed in 0fd55e7 |
targos
pushed a commit
that referenced
this pull request
Oct 28, 2018
Add overloads of the error generation/throwing methods that take an `Isolate*` argument, since the created objects don’t depend on the `Environment*` in question. Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way. PR-URL: #23879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
pushed a commit
that referenced
this pull request
Oct 28, 2018
Add overloads of the error generation/throwing methods that take an `Isolate*` argument, since the created objects don’t depend on the `Environment*` in question. Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way. PR-URL: #23879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
Add overloads of the error generation/throwing methods that take an `Isolate*` argument, since the created objects don’t depend on the `Environment*` in question. Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way. PR-URL: #23879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Nov 2, 2018
|
This does not land cleanly in |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overloads of the error generation/throwing methods
that take an
Isolate*argument, since the created objectsdon’t depend on the
Environment*in question.Also, remove
THROW_ERR_OUT_OF_RANGE_WITH_TEXT, which did thesame thing as
THROW_ERR_OUT_OF_RANGEin a more convoluted way.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes