Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky VM timeout test on Raspberry Pi #24238

Closed
wants to merge 1 commit into from
Closed

test: fix flaky VM timeout test on Raspberry Pi #24238

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 7, 2018

Fixes: #24120

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1535/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 7, 2018
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18408/

@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18409/

@Trott
test: fix flaky VM timeout test on Raspberry Pi
f0d5829 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: nodejs#24120
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

@addaleax @cjihrig I had to do some changes that are a little bit more extensive than the initial PR commit to get this to work. If you could take a look and reaffirm your approval, that would be appreciated. Thanks!

@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18410/

@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

Since this is intended to restore our CI from perma-yellow to green, I'd like to propose fast-tracking. 👍 here to approve.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 7, 2018
@Trott
Copy link
Member Author

Trott commented Nov 8, 2018

Landed in d8e06b2. Welcome back, green CI.

@Trott Trott closed this Nov 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2018
@Trott
test: fix flaky VM timeout test on Raspberry Pi
d8e06b2 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: nodejs#24120

PR-URL: nodejs#24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@Trott @BridgeAR
test: fix flaky VM timeout test on Raspberry Pi
415fcde 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: #24120

PR-URL: #24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@Trott @kiyomizumia
test: fix flaky VM timeout test on Raspberry Pi
872e1c3 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: nodejs#24120

PR-URL: nodejs#24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@codebytere
Copy link
Member

@Trott do you think you could backport this to v10.x?

@Trott
Copy link
Member Author

Trott commented Nov 29, 2018 •
edited
Loading

@Trott do you think you could backport this to v10.x?

@codebytere This will land cleanly after 5e5a945 and 095a602 are cherry-picked into the v10.x-staging branch.

After cherry-picking those two and then this commit, you probably then want to cherry-pick 9e33e86 to maximize the likelihood that your tests won't fail.

The lts-watch label on those two earlier PRs (for those first two commits above) can be removed IMO but you probably want to land all four of these commits one right after the other. They represent us working out kinks in the test over time and by landing them all together, you minimize problems you will have with test unreliability.

@codebytere
Copy link
Member

hmm actually this doesn't look like it can be landed on 10.x as it relies on 5e5a945 which relies on #22951 which was semver-major

@Trott Trott deleted the fix-24120 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky known_issues/test-vm-timeout-escape-nexttick
6 participants
@Trott @nodejs-github-bot @codebytere @addaleax @cjihrig @richardlau