Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x] backport "tools: update remark-preset-lint-node to v1.3.1" #24699

Closed
wants to merge 2 commits into from
Closed

[v11.x] backport "tools: update remark-preset-lint-node to v1.3.1" #24699

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 28, 2018

This is #24642 applied cleanly + two whitespace fixes that were included in 2c2e6ec38d1 (release commits are not backported)

@watilde @targos
doc: remove trailing whitespace
8e37905 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde @targos
tools: update remark-preset-lint-node to v1.3.1
e217d81 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1707/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v11.x labels Nov 28, 2018
targos pushed a commit that referenced this pull request Nov 30, 2018
@watilde @targos
doc: remove trailing whitespace
654bd65 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 30, 2018
@watilde @targos
tools: update remark-preset-lint-node to v1.3.1
e7fbdf5 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
Copy link
Member Author

targos commented Nov 30, 2018

Landed in 654bd65 and e7fbdf5

@targos targos closed this Nov 30, 2018
@targos targos deleted the backport-24642 branch November 30, 2018 14:07
@targos targos added this to Closed PRs in v11.x Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
No open projects
v11.x
  
Closed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@targos @nodejs-github-bot @watilde