Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: prepare tools/specialize_node_d.py for Python 3 #24797

Closed
wants to merge 1 commit into from
Closed

tools: prepare tools/specialize_node_d.py for Python 3 #24797

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 3, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 3, 2018
@addaleax addaleax added the python PRs and issues that require attention from people who are familiar with Python. label Dec 3, 2018
@Trott
Copy link
Member

Trott commented Dec 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19269/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19292/

@Trott
Copy link
Member

Trott commented Dec 7, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19297/

@Trott
Copy link
Member

Trott commented Dec 7, 2018

Landed in 7468c56

@Trott Trott closed this Dec 7, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2018
@Trott
tools: prepare tools/specialize_node_d.py for Python 3
7468c56 
PR-URL: nodejs#24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cclauss cclauss deleted the Py3-for-tools_specialize_node_d.py branch December 7, 2018 06:59
MylesBorins pushed a commit that referenced this pull request Dec 7, 2018
@MylesBorins
tools: prepare tools/specialize_node_d.py for Python 3
7cac76c 
PR-URL: #24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
tools: prepare tools/specialize_node_d.py for Python 3
ea7102a 
PR-URL: nodejs#24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
tools: prepare tools/specialize_node_d.py for Python 3
e6afaa3 
PR-URL: #24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
tools: prepare tools/specialize_node_d.py for Python 3
5bd7e43 
PR-URL: #24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
tools: prepare tools/specialize_node_d.py for Python 3
6a72d52 
PR-URL: #24797
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cclauss @Trott @addaleax @richardlau @BridgeAR @nodejs-github-bot