Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: truncate decimal values #24819

Closed

Commits on Jan 28, 2019

  1. timers: truncate decimal values

    Reverts some timers behavior back to as it was before
    2930bd1
    
    That commit introduced an unintended change which allowed non-integer
    timeouts to actually exist since the value is no longer converted to an
    integer via a TimeWrap handle directly.
    
    Even with the fix in
    e9de435
    non-integer timeouts are still indeterministic, because libuv does not
    support them.
    
    This fixes the issue by emulating the old behavior:
    truncate the `_idleTimeout` before using it.
    
    See comments in
    nodejs#24214
    for more background on this.
    Fishrock123 committed Jan 28, 2019
    Copy the full SHA
    10e70b6 View commit details
    Browse the repository at this point in the history