Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: prepare tools/testp.py for Python 3 #24890

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

commented Dec 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@Trott
Trott approved these changes Dec 7, 2018

@Trott Trott added the author ready label Dec 7, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19379/

(I'll be happy when the test-cli-syntax issue is fixed so we can stop running CI half a dozen times on every pull request. :-D)

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Landed in 5906530

@Trott Trott closed this Dec 10, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2018
tools: prepare tools/testp.py for Python 3
PR-URL: nodejs#24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

@cclauss cclauss deleted the cclauss:Py3-for-tools-test.py branch Dec 11, 2018

BethGriggs added a commit that referenced this pull request Dec 17, 2018
tools: prepare tools/testp.py for Python 3
PR-URL: #24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
tools: prepare tools/testp.py for Python 3
PR-URL: nodejs#24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
tools: prepare tools/testp.py for Python 3
PR-URL: #24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
tools: prepare tools/testp.py for Python 3
PR-URL: #24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
tools: prepare tools/testp.py for Python 3
PR-URL: #24890
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.