Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: code improvements of internet/test-dns #24927

Closed
wants to merge 3 commits into from
Closed

test: code improvements of internet/test-dns #24927

wants to merge 3 commits into from

Commits on Dec 9, 2018

  1. test: change 'for' loop to 'for of' loop

    @IlarionHalushka
    IlarionHalushka committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    2e3b5db View commit details
    Browse the repository at this point in the history

  2. test: remove unused parameters passed to functions

    @IlarionHalushka
    IlarionHalushka committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    d68a5c2 View commit details
    Browse the repository at this point in the history

  3. test: remove unnecessary 'assert.ok' 

    Removed 'assert.ok' that come before asserting that 'result'
is typeof 'object' because any object passes the 'assert.ok' check.
    @IlarionHalushka
    IlarionHalushka committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    3e5618f View commit details
    Browse the repository at this point in the history