Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: emit 'params' instead of 'data' for NodeTracing.dataCollected #24949

Closed
wants to merge 1 commit into from

Conversation

@kjin
Copy link
Contributor

commented Dec 10, 2018

All inspector event emissions emit an object of the shape { method: string, params: {} } except for NodeTracing.dataCollected. This PR changes this event to emit an object with a params field instead of data.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
Copy link
Member

left a comment

@addaleax

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

@nodejs/trace-events semver-patch?

@Trott

This comment has been minimized.

@ofrobots

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

Trace events are experimental, so my vote is semver-patch.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Landed in 49f1db4

@Trott Trott closed this Dec 14, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: nodejs#24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sam-github added a commit to sam-github/node that referenced this pull request Dec 14, 2018
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: nodejs#24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 18, 2018
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: #24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: nodejs#24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: #24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: #24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
src: emit 'params' instead of 'data' for NodeTracing.dataCollected
PR-URL: #24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.