Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: truncate output when maxBuffer is exceeded #24951

Closed
wants to merge 2 commits into from
Closed

child_process: truncate output when maxBuffer is exceeded #24951

wants to merge 2 commits into from

Commits on Jan 23, 2019

  1. test: add stdio checks to cp-exec-maxBuffer 

    Expands this test case to check what happens to stdout/stderr when
maxBuffer is exceeded.

Also changes how cases are checked so that assertion stacks are
tracable to their test case, aka 'make it actually debuggable'.
    @Fishrock123
    Fishrock123 committed Jan 23, 2019
    Copy the full SHA
    e23d8f2 View commit details
    Browse the repository at this point in the history

  2. child_process: truncate output when maxBuffer is exceeded 

    Preserves truncated output for `child_process.exec()` when `maxBuffer`
is exceeded.

This is particularly useful for commands which have indistinguishable
error codes for what output they produce.
    @Fishrock123
    Fishrock123 committed Jan 23, 2019
    Copy the full SHA
    2153075 View commit details
    Browse the repository at this point in the history