Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary linter comment #25013

Merged
merged 1 commit into from Dec 15, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 13, 2018

Some would say it's the linter's job to determine what looks right.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@BridgeAR
Copy link
Member

left a comment

😆

@lpinca
lpinca approved these changes Dec 13, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19562/

EDIT(cjihrig): CI run was green.

test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: #25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@cjihrig cjihrig force-pushed the cjihrig:what branch from 07c7877 to 0fdd23f Dec 15, 2018

@cjihrig cjihrig merged commit 0fdd23f into nodejs:master Dec 15, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:what branch Dec 15, 2018

BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: #25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: nodejs#25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: #25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: #25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: remove unnecessary linter comment
Some would say it's the linter's job to determine what
looks right.

PR-URL: #25013
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.