Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
test: add stdout check to test-esm-cjs-main #25073
Only red in the CI seems to be because the cleanup detected that @gireeshpunathil was testing something on CI:
21:45:21 ps awwx | grep Release/node | grep -v grep | cat 21:45:21 32506076 pts/2 A 0:00 /home/iojs/gireesh/exitrace/node/out/Release/node -e console.log('foobar'); 21:45:21 gmake: *** [test-ci] Error 1
If we see this happening a lot, we'll mark the node offline in Jenkins while they're doing their work (which is something we should do anyway, but we'd need some pretty responsive/on-duty Build folks to oversee it because right now we have them on one AIX node and @gabrielschulhof working on the other, so we'd have no AIX nodes left online potentially).
TL;DR Red CI here is unrelated and we'll Resume Build anyway.
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19585/