Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: reuse validateString of internal/validators #25074

Closed
wants to merge 1 commit into from
Closed

vm: reuse validateString of internal/validators #25074

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 16, 2018

The validateString function in vm.js is just one more judgement which validates whether prop !== undefined than the validateString function in internal/validators:

node/lib/vm.js

Lines 153 to 156 in 8f4b924

function validateString(prop, propName) {
if (prop !== undefined && typeof prop !== 'string')
throw new ERR_INVALID_ARG_TYPE(propName, 'string', prop);
}

node/lib/internal/validators.js

Lines 123 to 126 in 8f4b924

function validateString(value, name) {
if (typeof value !== 'string')
throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
}

So now just reuse the general validateString in validator.js totally.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Dec 16, 2018
antsmartian
antsmartian approved these changes Dec 16, 2018
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antsmartian
Copy link
Contributor

antsmartian commented Dec 16, 2018 •
edited by Trott
Loading

CI : https://ci.nodejs.org/job/node-test-pull-request/19581/ ✔️

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2018
@danbev
Copy link
Contributor

danbev commented Dec 20, 2018

Landed in e5966ef.

@danbev danbev closed this Dec 20, 2018
danbev pushed a commit that referenced this pull request Dec 20, 2018
@ZYSzys @danbev
vm: reuse validateString of internal/validators
e5966ef 
PR-URL: #25074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@ZYSzys ZYSzys deleted the validate-string-vm branch December 20, 2018 04:51
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@ZYSzys @MylesBorins
vm: reuse validateString of internal/validators
810e6ea 
PR-URL: #25074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@ZYSzys @MylesBorins
vm: reuse validateString of internal/validators
7df59f8 
PR-URL: #25074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
vm: reuse validateString of internal/validators
8e7403d 
PR-URL: nodejs#25074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@antsmartian antsmartian antsmartian approved these changes

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ZYSzys @antsmartian @danbev @jasnell @lpinca @watilde @targos @BethGriggs @nodejs-github-bot