Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove test-related GYP files #25097

Closed
wants to merge 1 commit into from

Conversation

Projects
8 participants
@targos
Copy link
Member

commented Dec 17, 2018

  • Less files to maintain.
  • We don't use them.
  • We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

/cc @ryzokuken

deps: remove test-related GYP files
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010
@targos

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

@Trott Trott added the author ready label Dec 18, 2018

@danbev

danbev approved these changes Dec 18, 2018

@ryzokuken
Copy link
Member

left a comment

Great PR! Thanks, @targos.

@targos

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

Landed in f0e4609

@targos targos closed this Dec 20, 2018

@targos targos deleted the targos:v8-gyp-no-tests branch Dec 20, 2018

targos added a commit that referenced this pull request Dec 20, 2018

deps: remove test-related GYP files
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: #25095
Refs: #25010

PR-URL: #25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

@targos targos added this to Don't land (ever) in v11.x Dec 28, 2018

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

deps: remove test-related GYP files
- Less files to maintain.
- We don't use them.
- We build with GN to run V8 tests.

Fixes: nodejs#25095
Refs: nodejs#25010

PR-URL: nodejs#25097
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.