New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix links in test/common/README.md #25172

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@vsemozhetbyt
Copy link
Member

vsemozhetbyt commented Dec 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Dec 21, 2018

There is one more link issue in common.getBufferSources(buf), but I am not sure what reference we should add for <BufferSource[]> type.

cc @JemBijoux and @addaleax as per #16042 where this section was added.

@vsemozhetbyt vsemozhetbyt added the doc label Dec 21, 2018

@lpinca

lpinca approved these changes Dec 21, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 24, 2018

doc: fix links in test/common/README.md
PR-URL: nodejs#25172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 24, 2018

Landed in 5570df4 🎉

@BridgeAR BridgeAR closed this Dec 24, 2018

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-test-common-links branch Dec 24, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

doc: fix links in test/common/README.md
PR-URL: #25172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

doc: fix links in test/common/README.md
PR-URL: #25172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

doc: fix links in test/common/README.md
PR-URL: nodejs#25172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment