Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use ZCtxt as a source for v8::Isolates #2547

Closed
wants to merge 1 commit into from
Closed

src: use ZCtxt as a source for v8::Isolates #2547

wants to merge 1 commit into from

Conversation

r-52
Copy link
Contributor

@r-52 r-52 commented Aug 25, 2015

Other methods like After already use ZCtxt as the source for Environment/ v8::Isolate objects, this commit applies the same style to the other missing methods (After sync and Write)

Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)
@Fishrock123 Fishrock123 added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 25, 2015
@trevnorris
Copy link
Contributor

LGTM

/cc @indutny

@indutny
Copy link
Member

indutny commented Sep 1, 2015

LGTM

@Fishrock123
Copy link
Contributor

CI for good measure: https://ci.nodejs.org/job/node-test-pull-request/295/

Fishrock123 pushed a commit that referenced this pull request Sep 14, 2015
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

LGTM Landed in 414e407, thanks!

@r-52 r-52 deleted the zlib-ctxt branch September 14, 2015 21:02
Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 15, 2015
7 tasks
rvagg pushed a commit that referenced this pull request Sep 15, 2015
Other methods like `After` already use ZCtxt as the source for
Enviroment/ v8::Isolate objects, this commit applies the same style
to the other missing methods (`After sync` and `Write`)

PR-URL: #2547
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Sep 15, 2015
@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants