New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: fix JSON escaping in node-report #25626

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@lundibundi
Copy link
Member

lundibundi commented Jan 21, 2019

Previously only simple escape sequences were handled
(i.e. \n, \t, r etc.). This commit adds escaping of other control
symbols in the range of 0x00 to 0x20.

Also, this replaces multiple find+replace calls with a single pass
replacer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
src,test: fix JSON escaping in node-report
Previously only simple escape sequences were handled
(i.e. \n, \t, r etc.). This commit adds escaping of other control
symbols in the range of 0x00 to 0x20.

Also, this replaces multiple find+replace calls with a single pass
replacer.

@lundibundi lundibundi added the C++ label Jan 21, 2019

@lundibundi

This comment has been minimized.

Copy link
Member Author

lundibundi commented Jan 21, 2019

Show resolved Hide resolved src/node_report_utils.cc Outdated
Show resolved Hide resolved src/node_report_utils.cc Outdated
Show resolved Hide resolved test/cctest/test_report_util.cc Outdated
@lundibundi

This comment has been minimized.

Copy link
Member Author

lundibundi commented Jan 21, 2019

@lundibundi

This comment has been minimized.

Copy link
Member Author

lundibundi commented Jan 22, 2019

@addaleax addaleax added the report label Jan 22, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 25, 2019

Landed in 80441c8.

@danbev danbev closed this Jan 25, 2019

danbev added a commit that referenced this pull request Jan 25, 2019

src,test: fix JSON escaping in node-report
Previously only simple escape sequences were handled
(i.e. \n, \t, r etc.). This commit adds escaping of other control
symbols in the range of 0x00 to 0x20.

Also, this replaces multiple find+replace calls with a single pass
replacer.

PR-URL: #25626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@gireeshpunathil gireeshpunathil referenced this pull request Jan 25, 2019

Closed

src: Add new perf flags in NODE_OPTIONS #25565

4 of 4 tasks complete

addaleax added a commit that referenced this pull request Jan 28, 2019

src,test: fix JSON escaping in node-report
Previously only simple escape sequences were handled
(i.e. \n, \t, r etc.). This commit adds escaping of other control
symbols in the range of 0x00 to 0x20.

Also, this replaces multiple find+replace calls with a single pass
replacer.

PR-URL: #25626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment