New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused uncaughtException handler #25641

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@addaleax
Copy link
Member

addaleax commented Jan 22, 2019

This has been unused since cbc3ef6.

Refs: #23053

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test: remove unused uncaughtException handler
This has been unused since cbc3ef6.

Refs: #23053
@lpinca

lpinca approved these changes Jan 22, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 24, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

fixup! test: remove unused uncaughtException handler
Co-Authored-By: addaleax <github@addaleax.net>
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

Landed in 573ec5b

@addaleax addaleax closed this Jan 27, 2019

@addaleax addaleax deleted the addaleax:test-tty-stdout-end branch Jan 27, 2019

addaleax added a commit that referenced this pull request Jan 27, 2019

test: remove unused uncaughtException handler
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

test: remove unused uncaughtException handler
This has been unused since cbc3ef6.

Refs: #23053

PR-URL: #25641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment