New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix issue with worker_threads docs #25712

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@leebyron
Copy link
Contributor

leebyron commented Jan 25, 2019

this example function returns a promise directly rather than implicitly via async/await

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Fix issue with worker_threads docs
this example function returns a promise directly rather than implicitly via async/await

@leebyron leebyron changed the title Fix issue with worker_threads docs doc: Fix issue with worker_threads docs Jan 25, 2019

@lpinca

lpinca approved these changes Jan 25, 2019

@vsemozhetbyt

This comment has been minimized.

vsemozhetbyt added a commit that referenced this pull request Jan 29, 2019

doc: fix issue with worker_threads docs
This example function returns a promise directly
rather than implicitly via async/await.

PR-URL: #25712
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jan 29, 2019

Landed in a0419dd
Thank you!

targos added a commit that referenced this pull request Jan 29, 2019

doc: fix issue with worker_threads docs
This example function returns a promise directly
rather than implicitly via async/await.

PR-URL: #25712
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment