Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace s_client in test-https-ci-reneg-attack #25720

Closed
wants to merge 1 commit into from
Closed

test: replace s_client in test-https-ci-reneg-attack #25720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
72 changes: 34 additions & 38 deletions test/pummel/test-https-ci-reneg-attack.js
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@ if (!common.opensslCli)
common.skip('node compiled without OpenSSL CLI.');

const assert = require('assert');
const spawn = require('child_process').spawn;
const tls = require('tls');
const https = require('https');
const fixtures = require('../common/fixtures');
Expand Down Expand Up @@ -63,50 +62,47 @@ function test(next) {
});

server.listen(0, function() {
const cmd = `s_client -connect 127.0.0.1:${server.address().port}`;
const args = cmd.split(' ');
const child = spawn(common.opensslCli, args);

child.stdout.resume();
child.stderr.resume();
const agent = https.Agent({
keepAlive: true,
});

// Count handshakes, start the attack after the initial handshake is done
let handshakes = 0;
let client;
let renegs = 0;

child.stderr.on('data', function(data) {
handshakes += ((String(data)).match(/verify return:1/g) || []).length;
if (handshakes === 2) spam();
renegs += ((String(data)).match(/RENEGOTIATING/g) || []).length;
});
const options = {
rejectUnauthorized: false,
agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a trailing comma?

};

child.on('exit', function() {
assert.strictEqual(renegs, tls.CLIENT_RENEG_LIMIT + 1);
server.close();
process.nextTick(next);
});
const { port } = server.address();

https.get(`https://localhost:${port}/`, options, (res) => {
client = res.socket;

let closed = false;
child.stdin.on('error', function(err) {
switch (err.code) {
case 'ECONNRESET':
case 'EPIPE':
break;
default:
assert.strictEqual(err.code, 'ECONNRESET');
break;
client.on('close', function(hadErr) {
assert.strictEqual(hadErr, false);
assert.strictEqual(renegs, tls.CLIENT_RENEG_LIMIT + 1);
server.close();
process.nextTick(next);
});

client.on('error', function(err) {
console.log('CLIENT ERR', err);
throw err;
});

spam();

// simulate renegotiation attack
function spam() {
client.renegotiate({}, (err) => {
assert.ifError(err);
assert.ok(renegs <= tls.CLIENT_RENEG_LIMIT);
setImmediate(spam);
});
renegs++;
}
closed = true;
});
child.stdin.on('close', function() {
closed = true;
});

// simulate renegotiation attack
function spam() {
if (closed) return;
child.stdin.write('R\n');
setTimeout(spam, 50);
}
});
}