New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: export workerData to ESM workers #25768

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@addaleax
Copy link
Member

addaleax commented Jan 28, 2019

Fixes: #25765

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 28, 2019

Show resolved Hide resolved lib/worker_threads.js Outdated
@GeorgeTaveras1231

This comment has been minimized.

Copy link

GeorgeTaveras1231 commented Jan 28, 2019

Impressive how quickly this was addressed. Thanks @addaleax!

@lpinca

lpinca approved these changes Jan 29, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 30, 2019

Landed in 8919169

@addaleax addaleax closed this Jan 30, 2019

@addaleax addaleax deleted the addaleax:worker-data-esm branch Jan 30, 2019

addaleax added a commit that referenced this pull request Jan 30, 2019

worker: export workerData to ESM workers
Fixes: #25765

PR-URL: #25768
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jan 30, 2019

worker: export workerData to ESM workers
Fixes: #25765

PR-URL: #25768
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment